nf-tower icon indicating copy to clipboard operation
nf-tower copied to clipboard

Testing of Pipeline Launchpad Feedback

Open ggabernet opened this issue 4 years ago • 5 comments

Hi, here is some feedback for the first tests of the Launchpad functionality.

The parameter json schema does not correspond to the version of the pipeline being launched. When launching a pipeline with Tower that has a Parameter json schema it seems to pick up the parameter json schema defined in the latest version of the pipeline, and not the one relative to the version being launched. Steps to reproduce:

  1. Define Pipeline launcher with nf-core/rnaseq v1.4.2 and test profile
  2. Launch pipeline: the launcher picks up the pipeline schema for RNAseq v3.0, which does not correspond to usage for 1.4.2
  3. Pipeline test fails due to a default parameter option in that schema that did not exist in nf-core/rnaseq v1.4.2:

Command launched:

nextflow run https://github.com/nf-core/rnaseq
		 -name suspicious_curran
		 -params-file nf-4cj5mzhofI8PqF.params.json
		 -with-tower https://scratch.staging-tower.xyz/api
		 -r 1.4.2
		 -profile test

Error log:

N E X T F L O W  ~  version 21.03.0-edge
Pulling nf-core/rnaseq ...
downloaded from https://github.com/nf-core/rnaseq.git
Launching `nf-core/rnaseq` [suspicious_curran] - revision: 3b6df9bd10 [1.4.2]
Invalid aligner option: star_salmon. Valid options: 'star', 'hisat2'

ggabernet avatar Apr 12 '21 14:04 ggabernet

Thanks Gisella, I've just released an updated version that should solve this problem. Also, the name constraint is more related now _ and uppercase should be allowed.

Unfortunately I needed to cleanup the entire DB.

pditommaso avatar Apr 12 '21 14:04 pditommaso

wow, that is speed! Thanks for addressing this!

ggabernet avatar Apr 12 '21 14:04 ggabernet

😄

pditommaso avatar Apr 12 '21 14:04 pditommaso

This is solved now for me!

ggabernet avatar Apr 12 '21 14:04 ggabernet

Good! 🎉

pditommaso avatar Apr 12 '21 14:04 pditommaso