seqan3 icon indicating copy to clipboard operation
seqan3 copied to clipboard

Updated PR for the printer design proposal

Open rrahn opened this issue 1 year ago • 1 comments

This PR builds upon the original proposal of @marehr (#3227).

I changed from the print static member function to overloading the function call operator of the printer classes. Using this idea, we can now test wether a printer is invocable for a given output stream and the streamable argument. I also refactored some of the original default_printer code to simplify it. Among others, the is_printer is not needed anymore as we can use the invocable concept. For investigating errors I kept the concept printable_with which is basically just an alias for the invocable concept. In addition, I added documentation. Once this is done, we can look for more debug_stream instances that can be replaced with the printer mechanism.

rrahn avatar Jun 12 '24 13:06 rrahn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview Jun 13, 2024 3:03pm

vercel[bot] avatar Jun 12 '24 13:06 vercel[bot]

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3259

seqan-actions avatar Jul 25 '24 13:07 seqan-actions

Codecov Report

Attention: Patch coverage is 98.10127% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.14%. Comparing base (4a0b3fe) to head (bb9edea).

:exclamation: Current head bb9edea differs from pull request most recent head 4c65dda

Please upload reports for the commit 4c65dda to get more accurate results.

Files Patch % Lines
...ude/seqan3/core/debug_stream/debug_stream_type.hpp 89.47% 2 Missing :warning:
include/seqan3/core/debug_stream/variant.hpp 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.02%     
==========================================
  Files         270      271       +1     
  Lines       11926    11955      +29     
  Branches      105      104       -1     
==========================================
+ Hits        11702    11733      +31     
+ Misses        224      222       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 25 '24 13:07 codecov[bot]