seppuku icon indicating copy to clipboard operation
seppuku copied to clipboard

Duplicated resources when Gradle builds

Open ghost opened this issue 6 years ago • 6 comments

https://github.com/seppukudevelopment/seppuku/blob/5ecfa1183d368290e71d6bacc85f3ad996227a1c/build.gradle#L125-L131

This causes duplicated resource entries when the binaries are being compiled. I have no issues at all running the client when this is removed, does anyone else?

ghost avatar Dec 01 '19 09:12 ghost

Client will run fine with or without, this was added as a fix for ForgeGradle when loading resources at runtime from the resources directory, without it the resource directory never loads when running in IDE, simply change the buildmode variable at the top of build.gradle to RELEASE and run gradle clean and then gradle build (assuming the SeppukuClassTransformer is also set to RELEASE)

uoil avatar Dec 01 '19 16:12 uoil

Weird, I'm unable to run from the IDE with the lines added but I can run it fine without them. I'll do some more testing, then.

ghost avatar Dec 01 '19 21:12 ghost

This usually happens when you try to build without using gradlew. Removing the /build folder and building again fixes it for me.

jvyden avatar Dec 04 '19 19:12 jvyden

Not the solution for this problem, unfortunately. The duplicated resources will always be there because of these lines...

https://github.com/seppukudevelopment/seppuku/blob/5ecfa1183d368290e71d6bacc85f3ad996227a1c/build.gradle#L125-L131

I just removed the lines in my own file and won't push it. Everything seems to work fine.

ghost avatar Dec 04 '19 22:12 ghost

For sake of the repository and clearing issues and since no one else has come up with anything, I'm closing this. Deleting the lines still works fine and has no issues with resources when building an artifact.

ghost avatar Dec 10 '19 18:12 ghost

This issue came up inside of the Discord finally, so we should address it and figure out what's exactly going on. We shouldn't need these lines at all, ForgeGradle should be doing all of that for us?

ghost avatar Dec 16 '19 07:12 ghost

Closing as the client builds fine. If you change to "RELEASE" in build.gradle, clear the cache with the gradle command, run gradle build. If that does not succeed do as above and remove the lines in the post above.

uoil avatar Dec 06 '22 02:12 uoil