migrate-mongo icon indicating copy to clipboard operation
migrate-mongo copied to clipboard

Published 20 hours ago • verified publisher icon seppevs

docs: added '{session}' options to Transactions API samples

Open Maximusya opened this issue 3 years ago • 3 comments

Added missing {session} options to Transactions API samples: each operation in the function passed to session.withTransaction must be associated with the session.

Resolves #382

Checklist
  • [x] README.md is updated

Maximusya avatar Aug 16 '21 12:08 Maximusya

i vote for merging this PR to have actual tested documentation

MikeKoval avatar Aug 17 '21 15:08 MikeKoval

Makes a lot of sense to update those docs

iyeldinov avatar Aug 19 '21 17:08 iyeldinov

I've included this PR in https://github.com/theogravity/migrate-mongo-alt

theogravity avatar Jan 10 '22 20:01 theogravity

this absolutely needs to be merged, we used the sample from the documentation for months thinking that it was sufficient to have the migrations be rolled back in case of error, which it is not.

ntr-forage avatar Jan 11 '23 01:01 ntr-forage

Merged and landed in v11.0.0. Sorry for the delay. Thank you for your contribution.

seppevs avatar Sep 25 '23 18:09 seppevs