IPED icon indicating copy to clipboard operation
IPED copied to clipboard

Published 20 hours ago • verified publisher icon sepinf-inc

#668 Event Transcript Parser

Open FelipeFcosta opened this issue 2 years ago • 1 comments

closes #668

FelipeFcosta avatar Aug 23 '22 19:08 FelipeFcosta

Thank you @FelipeFcosta!

lfcnassif avatar Aug 24 '22 12:08 lfcnassif

Hi @FelipeFcosta, I think I finished reviewing this. Strings could still be localized, but since we didn't find this artifact in real world cases, not sure if it is worth.

Please take a look to see if I messed something and try to finish the incomplete no-op unit test, so we can merge this, thank you for this work!

lfcnassif avatar Feb 27 '23 23:02 lfcnassif

Hi @FelipeFcosta, I think I finished reviewing this. Strings could still be localized, but since we didn't find this artifact in real world cases, not sure if it is worth.

Please take a look to see if I messed something and try to finish the incomplete no-op unit test, so we can merge this, thank you for this work!

Thanks @lfcnassif, will do

FelipeFcosta avatar Feb 28 '23 17:02 FelipeFcosta

Hi @lfcnassif, I finished the tests, thanks for the code improvements.

FelipeFcosta avatar Mar 02 '23 17:03 FelipeFcosta

Thank you @FelipeFcosta! I'll do the final review soon.

lfcnassif avatar Mar 02 '23 17:03 lfcnassif