HorizontalVariableListView icon indicating copy to clipboard operation
HorizontalVariableListView copied to clipboard

Measurement fix by @endryha (issue #1)

Open almozavr opened this issue 12 years ago • 4 comments

Prevents notifyDataSetChanged problems.

almozavr avatar Mar 15 '13 11:03 almozavr

Thanks but I pushed a new version just yesterday which doesn't use the mChildHeight anymore, because now children can have a variable height too. Can you pls check your patch against this new version?

sephiroth74 avatar Mar 15 '13 13:03 sephiroth74

Just checked out latest version (cf172019b4c68d702c40281ee054643918e754f0) It acts incorrectly: height takes all the space available like it is match_parent but it's not.

almozavr avatar Mar 15 '13 15:03 almozavr

you should pass a fixed layout_height, otherwise we need to check all the children heights, since they can have a variable height.

sephiroth74 avatar Mar 15 '13 15:03 sephiroth74

I know, you are talking about: http://stackoverflow.com/a/11295287/691993 But, it would be lovely to have an option to use wrap_content since it's not alway obvious which height to use and have to sacrifice some performance due to calculations. What do you think?

almozavr avatar Mar 15 '13 16:03 almozavr