libpeer icon indicating copy to clipboard operation
libpeer copied to clipboard

General improvements to libpeer

Open darkuranium opened this issue 2 years ago • 2 comments

So this is a batch of changes that should probably really be 3 pull requests; I made them a single one both out of convenience (esp. if it's approved) and since it's a RFC anyway.

  • Third-party shell script build is migrated to CMake (so that it no longer depends on make being the default CMake tool, among others); this is probably the most controversial change, so consider this pull request an RFC.
  • Make libpeer build successfully in Windows. Did not test in POSIXy systems (mostly due to laziness), though I expect any problems are going to be minor.
    • As an aside: There was a bug in the sample, fixed it.
  • Get the library working in Firefox, also enables trickle ICE.

darkuranium avatar Dec 02 '23 22:12 darkuranium

There's a bug in CMakeLists.txt that I spotted. Should be easily fixed; I'll make a new PR soon.

darkuranium avatar Dec 02 '23 23:12 darkuranium

Took a bit longer than expected, and I noticed another small issue. Fixed all of that now.

darkuranium avatar Dec 03 '23 01:12 darkuranium

Hello, because this PR failed to compile under linux, it cannot be merged. Sorry for that

sepfy avatar Jun 17 '24 08:06 sepfy