libpeer icon indicating copy to clipboard operation
libpeer copied to clipboard

Stack corruption if rtp packet size is 1400

Open aldoshkind opened this issue 3 years ago • 1 comments

Hi @sepfy ! I found an issue in surveillance example which possibly affects overall pear usage. Default mtu size of rtph264pay is 1400 url RTP packet buffer size is 1400 also url peer_connection_send_rtp_packet uses srtp_protect inside, which writes outside of provided buffer, which leads to stack corruption: note in libsrtp docs. I think to avoid this the only option is to inreased buffer size, but I cannot deduce how huge it should be. Please review this problem.

aldoshkind avatar Apr 12 '22 12:04 aldoshkind

Thanks for the suggestion! Let me look into it.

sepfy avatar Apr 14 '22 02:04 sepfy