deepdiff icon indicating copy to clipboard operation
deepdiff copied to clipboard

DeepDiff 6.1.0 no longer supports Python 3.6

Open patgarz opened this issue 3 years ago • 1 comments

Describe the bug A breaking change for Python 3.6 was included in DeepDiff 6.1.0.

Python 3.6.15 | packaged by conda-forge | (default, Dec  3 2021, 18:49:43) 
[GCC Clang 11.1.0] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import deepdiff
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/scrub/miniconda3/envs/py36/lib/python3.6/site-packages/deepdiff/__init__.py", line 10, in <module>
    from .diff import DeepDiff
  File "/Users/scrub/miniconda3/envs/py36/lib/python3.6/site-packages/deepdiff/diff.py", line 26, in <module>
    from deepdiff.serialization import SerializationMixin
  File "/Users/scrub/miniconda3/envs/py36/lib/python3.6/site-packages/deepdiff/serialization.py", line 106, in <module>
    'Pattern': re.Pattern,    
AttributeError: module 're' has no attribute 'Pattern'

To Reproduce import deepdiff in Python 3.6 with Deepdiff 6.1.0 installed

Expected behavior Package imports with no error.

OS, DeepDiff version and Python version (please complete the following information):

  • OS: Ubuntu 20LTS and MacOS Monterey 12.5.1
  • Python 3.6.15
  • DeepDiff 6.1.0

Additional context IMO --- Python 3.6 is end of life for almost a year now. I would recommend simply dropping support for Python 3.6 in deepdiff>=6 and noting that in docs. I did not have any issues once I pinned to a previous version.

patgarz avatar Aug 29 '22 15:08 patgarz

Hi @patgarz Thanks for reporting this. Yeah I had technically dropped the support since the test suite doesn't include py 3.6 anymore. I'm gonna update the docs.

seperman avatar Aug 29 '22 16:08 seperman

Hi @patgarz Looking at the git commits, I did fix the docs on 2022-09-04 to mention python 3.7+

seperman avatar Dec 12 '22 06:12 seperman