samila icon indicating copy to clipboard operation
samila copied to clipboard

Point Colors :rainbow:

Open sadrasabouri opened this issue 1 year ago • 1 comments

Reference Issues/PRs

#75

What does this implement/fix? Explain your changes.

  • c parameter added to plot method (similar to color)
  • cmap parameter added to plot method

sadrasabouri avatar Aug 08 '22 07:08 sadrasabouri

Codecov Report

Merging #143 (f709dbb) into dev (9c6fbea) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          463       505   +42     
  Branches        74        84   +10     
=========================================
+ Hits           463       505   +42     
Impacted Files Coverage Δ
samila/genimage.py 100.00% <ø> (ø)
samila/functions.py 100.00% <100.00%> (ø)
samila/params.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 08 '22 07:08 codecov-commenter

I wonder if the Codacy error is not valid here because our last choice is to use the type instead of instanceof.

sadrasabouri avatar Aug 14 '22 14:08 sadrasabouri

I wonder if the Codacy error is not valid here because our last choice is to use the type instead of instanceof.

It's not a big problem. We can ignore it 💯

sepandhaghighi avatar Aug 15 '22 08:08 sepandhaghighi