Senan Kelly comments

Results 231 comments of


                                            Senan Kelly

feat: stream timeOffset when not trancoding

what is transcodeOffset?

feat: stream timeOffset when not trancoding

oh yes this thing forgot that gonic returns that. i see the point of clients not knowing if it will be transcoded or not

Misc. small changes

hi , would you be able to make the 127.0.0.1 change separately please?

feature: Include genre and album's date/year in listenbrainz scrobble payload

hm I think this would need to be configurable. for example I use lastfm for tag genre metadata which quite often can be completely wrong (eg two artists with the...

feature: Include genre and album's date/year in listenbrainz scrobble payload

yeah you can have nonsense tags like that fine, but if any of them happen to be also part of the list of predefined genres, then it comes a genre...

Remove escaped HTML stuff from Trademarks

``` import html print(html.unescape('£682m')) ``` But maybe requests also has a thing for that On Fri 27 Apr 2018, 15:21 Brandon Ibbotson, wrote: > Example: > > Name: AT&T BUSINESSDIRECT...

make sure the bot has the right email and password in config

well i think if even they were in a yaml file or something, the plugins could access them

make sure the bot has the right email and password in config

~hunter2~ did it work?

Remove `songCount` form `getAlbumList` response

thanks, can you fix the tests with `env "GONIC_REGEN=*" go test ./...`

Request: Parse `format` param in `stream` request for per-request transcoding

i would love for this to be possible, but we need some extension to the spec for clients to list the availible formats. eg gonic might have opus, opus_rg, or...