sentora-core icon indicating copy to clipboard operation
sentora-core copied to clipboard

SMTP Password field is wrong type.

Open CasteyDaSilva opened this issue 9 years ago • 2 comments

SMTP Pass field is textarea instead of input with password type.

Change:

<textarea cols="30" rows="1" name="smtp_password"></textarea>

To:

<input type="password" name="smtp_password" placeholder="Type your smtp password here">

CasteyDaSilva avatar Nov 20 '15 22:11 CasteyDaSilva

Unfortunately, due to the way it is coded and the way it renders the input lines from the database, it cannot be changed in the manner you describe. Will look into it some more.

TGates71 avatar Nov 23 '15 18:11 TGates71

In this file: https://github.com/sentora/sentora-core/blob/master/modules/sentoraconfig/code/controller.ext.php Between line 51 and 52 add:

                if (strpos(ctrl_options::OutputSettingTextArea($rowsettings['so_name_vc']),'smtp_password') !== false) {
                    $fieldhtml = '<input type="password" name="smtp_password" value="'.$rowsettings['so_value_tx'].'">';
                }

It should look like this when done:

                }
                if (strpos(ctrl_options::OutputSettingTextArea($rowsettings['so_name_vc']),'smtp_password') !== false) {
                    $fieldhtml = '<input type="password" name="smtp_password" value="'.$rowsettings['so_value_tx'].'">';
                }
                array_push($res, array('cleanname' => ui_language::translate($rowsettings['so_cleanname_vc']),

Give it a test. Update pushed to master: https://github.com/sentora/sentora-core/blob/master/modules/sentoraconfig/code/controller.ext.php

TGates71 avatar Nov 23 '15 20:11 TGates71

@TGates71 , @MBlagui , Any updates on this?

Dukecitysolutions avatar Jan 11 '24 21:01 Dukecitysolutions

Was completed 9 years ago.

TGates71 avatar Jan 26 '24 02:01 TGates71