eo-learn-examples icon indicating copy to clipboard operation
eo-learn-examples copied to clipboard

add eo-crops

Open j-desloires opened this issue 3 years ago • 5 comments

Hi Sinergise team,

I made a small git repository using eo-learn to download and preprocess Sentinel and VHRS data (PlanetScope, Spot and Pleaides). I think it may interest some people, especially for crop monitoring.

I would like to thank ESA NoR program for the free Sentinel hub account.

Cheers, Johann

j-desloires avatar Feb 03 '22 10:02 j-desloires

Hi @j-desloires

That's great! Could I ask you to properly add eo-crops to the pull request (folder?), not just the link?

Best, Matej

batic avatar Feb 03 '22 10:02 batic

Hi @batic ,

Thank you for your interest regarding this repo! It should be ok now!

Best regards, Johann

j-desloires avatar Feb 03 '22 11:02 j-desloires

Hi @j-desloires

Any particular reason for closing the pull request? Is there something we can help with?

Matej

batic avatar Feb 07 '22 11:02 batic

HI @batic,

Thanks for your comment.

The repo just lacks some unit testing and to handle temporary files more efficiently, but I can do it within 2/3 weeks..!

I would be very happy to have your feedback, this is my first pull request and this is an opportunity to improve my python best practices.

Have a great day, Johann

j-desloires avatar Feb 07 '22 12:02 j-desloires

Great!

In the mean time, we'll have a look and give you some feedback. We plan to update (at least some) of the examples in the repository as well, so I'll add your PR to the "todo" list :)

Don't hesitate to reach out on forum as well.

batic avatar Feb 07 '22 12:02 batic