kube-fledged icon indicating copy to clipboard operation
kube-fledged copied to clipboard

Feature: Ability to pass labels/annotations to job pods

Open NetanelK opened this issue 1 year ago • 1 comments

Hi, currently we're running Istio on our clusters with istio-proxy sidecar injector. We would like to disable istio-proxy on kube-fledged cache pods.

Istio provides a custom label sidecar.istio.io/inject="false" which needs to be present on pod's metadata.

We'll need a way to pass those custom labels to kube-fledged, annotations can be done the same way. Another less preferred option is to deploy kube-fledged jobs into other namespace that imageCache resource namespace.

NetanelK avatar Aug 03 '23 12:08 NetanelK

Hi, Maybe we can simply add sidecar.istio.io/inject="false" in https://github.com/senthilrch/kube-fledged/blob/master/pkg/images/image_helpers.go#L52 ? I can create pr for this.

dyens avatar Feb 11 '24 17:02 dyens