sensu-plugins-process-checks
sensu-plugins-process-checks copied to clipboard
`check-process.rb` has too many options and is too hard to use
Basically it's great to have something that can do pretty much anything but with that comes extra complexity of understanding how to use it. I think there are a few things we can do:
- Simplify the code, it is needlessly complex
- Abstract some of the logic to libraries to make it easier to work with
- Make more options have no defaults and require specifying them, its impossible to have something with that many options and have sane defaults for everything.
- Reduce the scope of this check by splitting into different checks.
- Have better option names (one of the 2 hardest things in CS)
- Have better option descriptions
- Put in custom logic to try to trap situations that we see users commonly have options that do not make sense together.
This is motivated by several issues that I have come across as a maintainer and after much investigation it ended in basically not having defaults the user expects:
- #45
- #46
- #22