sensu-plugins-mysql icon indicating copy to clipboard operation
sensu-plugins-mysql copied to clipboard

Code and help text inconsistent for minimum thresholds in check-mysql-threads.rb

Open rwillmer opened this issue 7 years ago • 2 comments

The inline help says

Number of running threads under which we'll issue a warning/alert

but the code says

critical "MySQL currently running threads: #{run_thr}" if run_thr <= config[:mincrit].to_i warning "MySQL currently running threads: #{run_thr}" if run_thr <= config[:minwarn].to_i

Either the help should say "at which" or the code should say "<"

rwillmer avatar Jun 25 '17 09:06 rwillmer

If you decide which is better, I can do a PR if you want

rwillmer avatar Jun 25 '17 13:06 rwillmer

I think in general tend to expect the boundary itself to be included in the alert threshold so I would opt for the help changed. I would love a pr.

majormoses avatar Jul 02 '17 22:07 majormoses