sensu-plugins-aws

sensu-plugins-aws copied to clipboard

We are using sensu to monitor our AWS infrastructure. We have lots of ASG in every environments including prod, stage, qa, qe etc. and we are using lambda functions on...

bdshibly

AWS check-beanstalk-elb-metric.rb broken

1

./check-beanstalk-elb-metric.rb --help ```/var/lib/gems/2.4.0/gems/sensu-plugins-aws-10.0.0/lib/sensu-plugins-aws/cloudwatch-common.rb:3:in `': uninitialized constant CloudwatchCommon::Common (NameError) from /var/lib/gems/2.4.0/gems/sensu-plugins-aws-10.0.0/lib/sensu-plugins-aws/cloudwatch-common.rb:2:in `' from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in `require' from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:133:in `rescue in require' from /usr/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:40:in `require' from ./check-beanstalk-elb-metric.rb:30:in `'```

umairedu

No security creds should be passed from the commandline

11

All tokens, keys, etc should be read from a local config file, databag, etc. The less these tokens see the light of day the better

mattyjones

All checks should pull from a standard library

16

There should be a single set of functions/class that all the checks utilize, there is a large amount of duplicated code here that can be extracted out with minimal effort.

mattyjones

for instance: ``` ruby def statistics_options { start_time: config[:end_time] - config[:period], end_time: config[:end_time], statistics: ['Average'], period: config[:period] } end ``` (That method comes from check-ec2-network, many of the other metric...

bkett

Plugin Tests

2

This is more of a question as I continue to work on the rewrite. I understand rspec is required for some of the ci tools in the gem but I'd...

bkett

Standardize the fetching of creds

5

Some of the plugins can pull from the env and others require CLI. In the long run we want to do this 100% by config, but for now we should...

tas50

Nearly every plugin uses very high CPU usage

9

Every check on it's own will eat up 91%+ of CPU. Even when you pass nothing to it, just "check-rds.rb" and it spikes.

NeckBeardPrince

Ensure support for multiple objects in all checks

1

AWS plugins are very resource intensive (sdk load time). We need to make sure that when a plugin runs it can check all resource types so the user doesn't have...

tas50

DDB tests don't check all tables

1

We have 415 or so ddb tables but when I run the ddb check scripts (either throttle or capacity) they stop at 100; I'm assuming pagination needs to be added.

RAR