sensu-plugins-aws icon indicating copy to clipboard operation
sensu-plugins-aws copied to clipboard

Using aws service gems

Open rajiv-g opened this issue 5 years ago • 5 comments

Pull Request Checklist

#293

General

  • [ ] Update Changelog following the conventions laid out here

  • [ ] Update README with any necessary configuration snippets

  • [ ] Binstubs are created if needed

  • [ ] RuboCop passes

  • [ ] Existing tests pass

New Plugins

  • [ ] Tests

  • [ ] Add the plugin to the README

  • [ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

rajiv-g avatar May 06 '19 13:05 rajiv-g

Looks like this did not install them correctly. Lots of:

GemWrappers: Can not wrap missing file: c_rehash
GemWrappers: Can not wrap missing file: makedepend
GemWrappers: Can not wrap missing file: check-banner.rb
GemWrappers: Can not wrap missing file: rake-compiler
GemWrappers: Can not wrap missing file: sensu-translator
GemWrappers: Can not wrap missing file: check-uptime.rb
GemWrappers: Can not wrap missing file: metrics-uptime.rb
GemWrappers: Can not wrap missing file: aws.rb
GemWrappers: Can not wrap missing file: check-head-redirect.rb
GemWrappers: Can not wrap missing file: metrics-http-json.rb
GemWrappers: Can not wrap missing file: check-last-modified.rb
GemWrappers: Can not wrap missing file: check-http.rb
GemWrappers: Can not wrap missing file: metrics-curl.rb
GemWrappers: Can not wrap missing file: check-http-cors.rb

And ultimately did not install the checks into /opt/sensu/embedded/bin/ correctly.

See conversation in https://github.com/sensu-plugins/sensu-plugins-aws/issues/293

ZZ

zeninfinity avatar May 06 '19 20:05 zeninfinity

@majormoses @zeninfinity I can successfully install these in sensu & binstubs are created as well in embedded sensu ruby. But still it took more time to parse the dependencies of aws-sdk in gemspec.

rajiv-g avatar May 07 '19 15:05 rajiv-g

does this PR superseded #335?

majormoses avatar May 09 '19 01:05 majormoses

@majormoses Yes its superseded for #335, But need your ideas/suggestion on https://github.com/sensu-plugins/sensu-plugins-aws/issues/293#issuecomment-490754441

rajiv-g avatar May 09 '19 06:05 rajiv-g

Sorry for the long silence, I replied on the PR and am ready to move forward with something as long as we are moving forward and not dropping any features that rely on v3 sdks.

majormoses avatar Oct 05 '20 00:10 majormoses