SensioBuzzBundle
SensioBuzzBundle copied to clipboard
sensiolabs
Tagging request
This request is the result of my erroneous pull request yesterday. One of the bundles I am using in my current project requires Buzz 0.6. Due to the BC breaks introduced in 0.7, the SensioBuzzBundle does not work with Buzz 0.6, however the composer file indicates it does. I'm going to submit a PR to the bundle that is causing me the issue to update it to 0.7, but I think the issues in this bundle need to be fixed.
As @stof pointed out earlier, this bundle should not have a dependency on Buzz >= 0.6. It would be very useful to me, and probably others using this bundle, if changes could be made to restore this bundles compatibility with 0.6 and a tag made. Then if both the dependency and code are updated to support 0.7 users with a dependency on 0.6 will not be left out of the fun.
I'm happy to provide the PR's if you think this is a worthwhile approach.
Sorry for the quite long delay... Do we need to update the Buzz dependency to > 0.6 only or >= 0.7 ?
I don't think it has been. The issue was that Buzz 0.6 and this bundle weren't compatible, despite the listed dependency being >=0.6. It's been a long time and I don't have a good grasp on the facts any more, but if I remember correctly it was something to do with the exception classes changing between 0.6 and 0.7.
I found the issue in the first place because another bundle I was using required Buzz 0.6 explicitly, but that bundle was changed. I'm happy to retest this, but I won't have time till the weekend, or early next week.
To clear things up I have checked this out in a bit more detail now. SensioBuzzBundle v0.2+ is not compatible with Buzz v0.6. This means that the dependency of >=0.6 is incorrect in the v0.2 and v1.0.0 tags. I have not tested which Buzz version is required for each of these versions, but I can say for sure v0.6 will not work.
If another dependency specifies Buzz v0.6 precisely then this bundle breaks. This actually happened to me.
Are you sur This bundle can not be install with buzz = 0.6 ?
But anyway, I think the issue is not in this repository but in the other one. asking for 0.6 is very too restrictive.
BTW, what is the other repository ?
@lyrixx If this bundle is nto compatible with 0.6, asking for >=0.6 is also wrong. If the minimal require is 0.7, it should tell it properly
@lyrixx https://github.com/sensiolabs/SensioBuzzBundle/commit/6ed5d870803fde0150faffddc5b7c99daa8ecf78 is indeed bumping the requirement to 0.7
The problem wasn't that it wouldn't install, it's that it would install but wouldn't work. The other bundle was HWIOAuth (referenced above), but the hard dependency was fixed very quickly there and I forgot about the issue in here.
~0.7 sounds good to me.
Anything happening with this? I notice there is a PR(#19) making this change now too.