SensioBuzzBundle icon indicating copy to clipboard operation
SensioBuzzBundle copied to clipboard

Add DataCollector

Open Seldaek opened this issue 12 years ago • 12 comments

Adding the DataCollector stuff from https://github.com/juliendidier/BuzzProfilerBundle to see it all in the profiler would be great.

/cc @juliendidier

Seldaek avatar Apr 17 '12 13:04 Seldaek

I think this is not the job of SensioBuzzBundle. Same as BuzzProfileBundle, which is not his job to generate default buzz service definitions.

juliendidier avatar Apr 17 '12 13:04 juliendidier

Yeah but having to add two bundles just for an http client is kind of annoying. Why not just have it all in one and make the profiler optional?

Seldaek avatar Apr 17 '12 13:04 Seldaek

BuzzProfilerBundle is for dev environments. I think SensioBuzzBundle must be used in prod or whatever.

juliendidier avatar Apr 17 '12 13:04 juliendidier

Yeah but you can have just one bundle with some features only enabled in dev. I think the added complexity of having two bundles is not really justified for such a small amount of code. It's also confusing when you are looking for a bundle, if you need to figure out you need to use the two together. This is not very common.

Seldaek avatar Apr 17 '12 13:04 Seldaek

IMHO, if you can't write yourself this file https://github.com/sensio/SensioBuzzBundle/blob/master/Resources/config/buzz.xml in your projects, you are very lazy. :)

With Symfony2, you can find a plethora of bundles for anything. That's why SensioBuzzBundle was made.

But everyday, I use Buzz for several projects, and I never searched a bundle to declare buzz as service. Because a bundle for that is really useless.

Isn't it?

juliendidier avatar Apr 17 '12 13:04 juliendidier

Well yeah, I'm not saying there is a huge need for a buzz bundle to define the services, but if you're gonna add a bundle for the profiler, it might as well define the service too I would say.

Anyway, I guess I'll drop this.

Seldaek avatar Apr 17 '12 14:04 Seldaek

You're not the first to ask for this issue ;)

juliendidier avatar Apr 17 '12 14:04 juliendidier

Well then maybe that should tell you that the way it is now is confusing. If you don't want to fix the problem, at least adding a note in the README would be nice.

Seldaek avatar Apr 17 '12 14:04 Seldaek

There was once a discussion about merging both bundles. But nobody took some time to do it.

Btw, BuzzProfilerBundle was written at the time of Buzz 0.4. Buzz 0.5 offers a better way to manage the profiling

stof avatar Apr 17 '12 17:04 stof

I currently have no time to work on that but I'd appreciate that the SensioBuzzBundle includes a profiler.

marcw avatar Apr 19 '12 09:04 marcw

+1

lsmith77 avatar Oct 30 '12 09:10 lsmith77

Profiling buzz calls from BuzzProfilerBundle is not well developed. It deals with clients. It was not a good idea.

See https://github.com/juliendidier/BuzzBundle/blob/master/DataCollector/BuzzDataCollector.php for a better profiling implementation.

juliendidier avatar Oct 30 '12 10:10 juliendidier