litehm2 icon indicating copy to clipboard operation
litehm2 copied to clipboard

build fails on add_ethernet() parameter tx_write_only

Open nitej opened this issue 2 years ago • 2 comments

It appears that the pull request that added the tx_write_only parameter for add_ethernet() was later updated to a new argument format specifying txslots_write_only. See enjoy-digital/litex@7fa7a4c72a994955637cf13ac760c32e0845604a

nitej avatar Jul 14 '23 16:07 nitej

Yes, thanks, I'll fix that with my next push. I assume you already fixed that locally?

sensille avatar Jul 17 '23 17:07 sensille

Yes, I updated tx_write_only = True to txslots_write_only=True on my local copy and it built the bitstream. I'm assuming the option for rxslots_write_only should be left at the default value of True, right?

nitej avatar Jul 17 '23 21:07 nitej