pdfjs_viewer-rails icon indicating copy to clipboard operation
pdfjs_viewer-rails copied to clipboard

Published 20 hours ago • verified publisher icon senny

Viewer origins

Open siegy22 opened this issue 9 years ago • 9 comments

closes #12, closes #16

@andyweiss1982 and @senny have a 👀

siegy22 avatar Jul 29 '16 08:07 siegy22

@MattFenelon can you get your use-case to work with this addition?

senny avatar Jul 29 '16 08:07 senny

@siegy22 A test-case needs to make sure the env variable has an effect. Otherwise we are going to loose this on an update.

senny avatar Jul 29 '16 09:07 senny

Let's wait for feedback if this addresses the need voiced by others.

senny avatar Jul 29 '16 09:07 senny

That's okay for me 👌

siegy22 avatar Jul 29 '16 09:07 siegy22

This looks great, thanks for looking at it. I won't be able to test it until Monday now.

As you own _viewer.html, rather than change viewer.js, could you modify HOSTED_VIEWER_ORIGINS in a js file loaded after viewer.js?

MattFenelon avatar Jul 29 '16 16:07 MattFenelon

Hey @MattFenelon I opened another pr ( #19 )

I explored a little "bug" in the code. Gonna fix this tommorow!

siegy22 avatar Jul 29 '16 16:07 siegy22

What's the latest on this?

fatuhoku avatar Oct 13 '16 12:10 fatuhoku

Any updates on this? When are you planning to merge this? I would really like to have configurable origins :'(

monochrome-particles avatar Jan 05 '17 04:01 monochrome-particles

it's useful when viewing PDF saved in S3 or cloud service

raykin avatar Jul 06 '17 07:07 raykin