emacs-eclim icon indicating copy to clipboard operation
emacs-eclim copied to clipboard

Why aren't the pull requests being reviewed?

Open nloyola opened this issue 10 years ago • 12 comments

Is someone in charge of this project? Can we get some feedback on when the pull requests will be reviewed and acted on?

nloyola avatar Nov 25 '15 01:11 nloyola

I can speak only for myself. My desire to code after hours is quite low and that is the reason I'm so silent lately. I'll rearrange some things in my day week schedule and let's see how that will work out for me. Maybe I find some time. I can't promise anything more then I'll try.

Of course, if someone is interested in helping maintaining it's good idea to be around, evaluate changes in PRs and give some feedback. Write some tests maybe. It's always good to have larger test suite. I'm more confident when merging.

kleewho avatar Nov 25 '15 10:11 kleewho

I interested in helping. I started writing tests 2 weeks ago, but then gave up since I never received any comments back on my pull requests. I can add another pull requests with the tests I have so far.

nloyola avatar Nov 25 '15 16:11 nloyola

@kleewho @nloyola Thank you for all the developers of the emacs-eclim, I hope this package will keepalive

ghost avatar Nov 25 '15 16:11 ghost

@nloyola please do that

kleewho avatar Dec 01 '15 15:12 kleewho

Didn't someone mentioned about the possibility of making this into a team account project?

gopar avatar Dec 16 '15 03:12 gopar

@gopar @nloyola @zwb-ict I'm doing it right now. It's pointless to keep the situation like we have right now. I'll post all details shortly (give me a two days to set it up and to think what else needs to be changed)

kleewho avatar Dec 16 '15 09:12 kleewho

Thank you @kleewho.

nloyola avatar Dec 16 '15 15:12 nloyola

Hell you can all figure out what needs to be done. I made @jchochli, @nloyola, @gopar administrators there although @jchochli was even more silent then I was. I hope that with new ppl that are actually using emacs-eclim the situation with stalled pull requests will go away.

What definitely needs to be done is this https://github.com/milkypostman/melpa/blob/b9faeb6d910d686cbcafe7d12e0bcf62a85689bd/recipes/emacs-eclim.

Organization is here https://github.com/emacs-eclim and the repo here https://github.com/emacs-eclim/emacs-eclim. I send invitations to organization as well so there's a chance that more acctive users will be in charge of this project.

kleewho avatar Dec 16 '15 18:12 kleewho

Thanks so much for doing this @kleewho. I'll push my changes soon.

nloyola avatar Dec 16 '15 18:12 nloyola

@kleewho thanks, i am lurking and would still like to contribute.

jchochli avatar Dec 16 '15 19:12 jchochli

And you're still able too cause you're an admin ;)

śr., 16 gru 2015, 20:20 James Chochlinski użytkownik < [email protected]> napisał:

@kleewho https://github.com/kleewho thanks, i am lurking and would still like to contribute.

— Reply to this email directly or view it on GitHub https://github.com/senny/emacs-eclim/issues/265#issuecomment-165215347.

kleewho avatar Dec 16 '15 23:12 kleewho

Congrats on moving forward! :thumbsup:

dgutov avatar Dec 24 '15 00:12 dgutov