cabbage icon indicating copy to clipboard operation
cabbage copied to clipboard

New version of emacs-eclim & completion setup stuff

Open fred-o opened this issue 12 years ago • 9 comments

Hi, I've reworked the completion code in emacs-eclim, and correspondingly updated the version in cabbage.

Also, an older change which fixed indenting of certain methods in java code seems to have snuck in as well.

fred-o avatar Dec 05 '12 20:12 fred-o

Could you rebase the branch, to remove your local merge commits?

Thanks very much for the work! :heart:

senny avatar Dec 06 '12 08:12 senny

Rebased!

fred-o avatar Dec 09 '12 14:12 fred-o

@jone noticed that this change executes code for all installs that have the completion bundle enabled. I'm not sure if we should set cabbage-java-use-eclim to nil and then set it to t in the bundles, that actually make use of eclim. This would mean, that if I don't have the java-bundle (or other bundles using eclim) enabled, it won't enable eclim within the completion bundle.

@fred-o what do you think?

senny avatar Dec 09 '12 17:12 senny

If the eclim sources have a decent fallback we could also use separate completion frameworks (e.g. auto-complete-eclim and company-mode-eclim).

jone avatar Dec 09 '12 18:12 jone

Sorry I forgot to follow up on this. I guess we could make nil the default for cabbage-java-use-eclim, but I suspect it could be tricky to enable it automatically in other bundles as we would be very dependent on the order the bundles are loaded. Better then to have the user enable eclim exlicitly.

fred-o avatar Dec 19 '12 19:12 fred-o

@fred-o could we detect of a working eclim installation is present? If so we can set the variable to t if an installation exists and use nil otherwise.

senny avatar Dec 19 '12 20:12 senny

sorry, hit the wrong button :neckbeard:

senny avatar Dec 19 '12 20:12 senny

@senny I think it'd be tricky to detect the installation correctly.

fred-o avatar Jan 15 '13 19:01 fred-o

/cc @jone

so I think we need to find a solution to make it nil by default and enable it from the bundles. I think (defvar) for the default and (setq) to override should work.

senny avatar Jan 16 '13 08:01 senny