python-video-converter icon indicating copy to clipboard operation
python-video-converter copied to clipboard

Sickbeard-mp4-automator merge

Open mdhiggins opened this issue 9 years ago • 4 comments

Updated the modifications made in Sickbeard mp4 automator to the latest version of python-video-converter in such a way that they are backwards compatible with prior version unlike my last pull attempt.

Changes made here add the ability to output files with multiple audio and subtitle tracks taking advantage of FFMPEGs -map function. Can pull from multiple or single sources. to create complex files with different tracks.

Options are presented as nested dictionaries now but previously used style dictionaries are still compatible.

Tests will need to be updated

mdhiggins avatar Mar 02 '15 21:03 mdhiggins

Looks like a lot of my changes from the pull request I made a year ago have found their way into the project which is great. I wanted to update my script to use the latest version of your converter but I still need the greater level of functionality. This time however, I made some changes so that I don't break backwards compatibility. In my (albeit limited) testing my script is working as it previously did and I'm also able to use the readme example (using the original style options) with no problems either.

mdhiggins avatar Mar 02 '15 21:03 mdhiggins

nice! +1

cytec avatar Mar 03 '15 02:03 cytec

Updated the script some more to pass the various tests. had to modify some of the tests due to the way command line parameters being generated were different but its passing now.

mdhiggins avatar Mar 05 '15 06:03 mdhiggins

Any info on this? Any additional changes you require?

mdhiggins avatar Mar 11 '15 22:03 mdhiggins