APIv3-typescript-library icon indicating copy to clipboard operation
APIv3-typescript-library copied to clipboard

Published 20 hours ago • verified publisher icon sendinblue

fix imports for 'request' and 'http'

Open lorenzogm opened this issue 4 years ago • 8 comments

fix #16

lorenzogm avatar Feb 19 '21 20:02 lorenzogm

@lorenzogm I just tried this and seems to work https://itnext.io/automatically-remove-all-unused-typescript-imports-in-a-project-afd4eb0e84b7 Would you include it in your MR or want me to do a new one?

matiasbastos avatar Feb 24 '21 01:02 matiasbastos

@matiasbastos I think you can add them. Anyway we need someone with write permissions to merge those PRs

lorenzogm avatar Feb 26 '21 15:02 lorenzogm

You think that this PR will take longtime to be merged and release?

jomaora avatar Mar 01 '21 11:03 jomaora

@matiasbastos I think you can add them. Anyway we need someone with write permissions to merge those PRs

Sorry for the delay, this evening will do it!

matiasbastos avatar Mar 01 '21 11:03 matiasbastos

Hi Please make all the required changes. I will discuss it with the team and then will proceed further. Thanks for collaborating on the project.

aayush-sib avatar Mar 01 '21 12:03 aayush-sib

Hi @aayush-sib Pushed my changes here https://github.com/sendinblue/APIv3-typescript-library/pull/24

matiasbastos avatar Mar 01 '21 17:03 matiasbastos

@aayush-sib can we merge this PR?

lorenzogm avatar Mar 08 '21 22:03 lorenzogm

Hi @lorenzogm

Sorry for the delay, can you please create a branch from this project only and push changes to that branch instead of pushing it to the forked project?

Thanks!!

aayush-sib avatar Mar 09 '21 05:03 aayush-sib