Adding SendGrid addon on Heroku uses Basic Authentication with Username and Password

[vfonic]

I know this is not the most relevant place to submit this issue, but I got lost trying to find a contact on your website. Now you can close this issue and wait for this to start failing or you can forward it to the right place through your internal channels. Thank you!

Issue Summary

The Basic Authentication with Username and Password is deprecated and will most likely stop working on January 20th.

However, SendGrid addon on Heroku still uses Basic Authentication. This will cause issues for anyone who tries to add SendGrid addon and use it on Heroku. Developers will have to manually switch from Basic Auth to API key auth.

Steps to Reproduce

1. Create new app on heroku
2. Add SendGrid addon
3. Check environment variables created by SendGrid addon

Actual:

The environment variables created are:

SENDGRID_PASSWORD: 'xxx'
SENDGRID_USERNAME: [email protected]

Expected:

I'd expect something of the kind:

SENDGRID_PASSWORD: 'xxx'
SENDGRID_USERNAME: apikey

or

SENDGRID_API_KEY: 'xxx'

...and update heroku documentation.

Related links

https://devcenter.heroku.com/articles/sendgrid#actionmailer https://sendgrid.com/docs/for-developers/sending-email/upgrade-your-authentication-method-to-api-keys