sendgrid-nodejs icon indicating copy to clipboard operation
sendgrid-nodejs copied to clipboard

fix(client): use ".default" named export when importing axios

Open tusharf5 opened this issue 1 year ago • 4 comments

Using this package with the latest axios with webpack results in an error, using a .default import which is officially supported by axios fixes that issue.

For more context, we are using sendgrid heavily at our org (tens of millions of emails per month) and upgrading to axios > 0 broke sendgrid and we narrowed it down to the import statement that's changed in this PR.

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added the necessary documentation about the functionality in the appropriate .md file
  • [ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

tusharf5 avatar Jul 05 '24 19:07 tusharf5

+1

naeemdadi-kunai avatar Aug 26 '24 12:08 naeemdadi-kunai

Hey @tusharf5, thanks for this. Meanwhile have you found any alternative to solve this without downgrading to < 1?

naeemdadi-kunai avatar Aug 26 '24 12:08 naeemdadi-kunai

We use patch-package to update the package @naeemdadi-kunai

Shottr 2024-08-26 20 24 31

tusharf5 avatar Aug 26 '24 14:08 tusharf5

We use patch-package to update the package @naeemdadi-kunai

Shottr 2024-08-26 20 24 31

Thank you @tusharf5, this is really helpful!

naeemdadi-kunai avatar Aug 27 '24 13:08 naeemdadi-kunai