sendgrid-java icon indicating copy to clipboard operation
sendgrid-java copied to clipboard

Helpers do not have all properties

Open lopenchi opened this issue 4 years ago • 2 comments

Issue Summary

Checking the request body for mail/send (https://docs.sendgrid.com/api-reference/mail-send/mail-send), it was discovered that helper classes provided in this library are old and do not contain all info needed.

Errors found:

  • In mail_settings object, there are some properties that are not in MailSettings helper class: bypass_spam_management, bypass_bounce_management and bypass_unsubscribe_management

  • In MailSettings helper class there is a property bcc that it is not described anymore in the request body

lopenchi avatar Sep 07 '21 20:09 lopenchi

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

JenniferMah avatar Sep 09 '21 21:09 JenniferMah

@JenniferMah hi folks - added a PR to address the first point: https://github.com/sendgrid/sendgrid-java/pull/707

arkitex avatar Nov 01 '21 14:11 arkitex