sendgrid-go icon indicating copy to clipboard operation
sendgrid-go copied to clipboard

Published 20 hours ago • verified publisher icon sendgrid

feat: go 1.20 compatibility

Open nmemoto opened this issue 1 year ago • 8 comments

Fixes

This PR updates the application to be compatible with go 1.20

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added the necessary documentation about the functionality in the appropriate .md file
  • [x] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

nmemoto avatar Jun 16 '23 03:06 nmemoto

All tests are green https://github.com/nmemoto/sendgrid-go/actions/runs/5285866793/jobs/9564752335

nmemoto avatar Jun 16 '23 03:06 nmemoto

Any update on this? @childish-sambino

Abonive avatar Sep 05 '23 19:09 Abonive

When do you plan to review/approve this PR ? @childish-sambino

natiiaparicio avatar Oct 11 '23 18:10 natiiaparicio

What's the blocker to this being merged?

porterctrlz avatar Oct 26 '23 00:10 porterctrlz

Also runs cleanly on 1.21: https://github.com/controlzee/sendgrid-go/actions/runs/6713922883, but I'll take what I can get in terms of merged PRs

porterctrlz avatar Nov 06 '23 23:11 porterctrlz

No maintenance here?

lopezator avatar Dec 18 '23 15:12 lopezator

@tiwarishubham635 would you be placed to merge stuff like this?

porterctrlz avatar Jul 19 '24 20:07 porterctrlz