sendgrid-csharp icon indicating copy to clipboard operation
sendgrid-csharp copied to clipboard

fix: reading from a stream that sends its data in multiple chunks

Open 0wnlife opened this issue 2 years ago • 0 comments

Fixes

A bug where the stream is only read once and the return value length isn't validated against the total expected length. Example: if a stream sends the data in 4 chunks only the first chunk is read from the stream.

Adds

A test with a stream that simulates sending the data in seperate (configurable) chunks.

Checklist

  • [x] I acknowledge that all my contributions will be made under the project's license
  • [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x] I have read the Contribution Guidelines and my PR follows them
  • [x] I have titled the PR appropriately
  • [x] I have updated my branch with the main branch
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added the necessary documentation about the functionality in the appropriate .md file
  • [x] I have added inline documentation to the code I modified

0wnlife avatar Aug 03 '22 08:08 0wnlife