nodemailer-sendgrid-transport
nodemailer-sendgrid-transport copied to clipboard
sendgrid
Upgrade to new Sendgrid NodeJS 4.x (including support for categories)
Ok done now.
Node: For some reason the sendgrid folks had made the tests 4 space indented, but the code itself 2 space indents... now everything is 2 space indented
@glesage it would be great if you could publish your fork as a scoped package (https://docs.npmjs.com/getting-started/scoped-packages#publishing-a-scoped-package) on npm. This way we can update our code with your version, while keeping the official version in the hands of the sendgrid folks. What do you think?
@glesage I tested your code with latest sendgrid and your "simple.js" example. it sends the email, but without the attachment. For reference, here is the email I got:
Content-Type: multipart/alternative; boundary=a695d6af36ee3c70b3499262a0295df31062e27e1fb7c6419bb7947fdccf
Date: Wed, 29 Mar 2017 08:07:05 +0000
From: [email protected]
Mime-Version: 1.0
To: [email protected]
Message-ID: <[email protected]>
Subject: Hi there
X-SG-EID: HqT4kUctyE3kW2PUSsq91RU8LLKTVuz0GmTxV/aozaQtOMmmETFfcCXs8ttd+SgQq7CBmLntkDeEWg
kLbsQ30qR5s4SdeZZbjYGhHMQVk+EHmqtbskuwkLTlODISEX0B3fKYbLTuahK70uajTVjffa+02PMF
oPPcx5Om4PLXg1Vq95Pl044mlhcXZGWvX7rx
--a695d6af36ee3c70b3499262a0295df31062e27e1fb7c6419bb7947fdccf
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Mime-Version: 1.0
Awesome sauce=
--a695d6af36ee3c70b3499262a0295df31062e27e1fb7c6419bb7947fdccf
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
Mime-Version: 1.0
<b>Awesome sauce</b><img src=3D"https://u5022465.ct.sendgrid.net/wf/open?up=
n=3DnMvfCq7WiY0yYcCX2AtMT-2BrDmRSsjXvx5pKaPAhucVuT8WTPS6aCzTuVw6qd4-2BO9T4G=
nYTGcv0cfbrmlRfGNsRJAYIw85LSqvcPu-2BQbN2MowzRSoxS-2Fl84DPdQB-2FKyf-2BVXmtIX=
TbZ-2FEO-2Br5rPZJ9uTqDsL-2B0AX-2B-2FyEFPtZeymC4wcJsO5-2BVRMc-2FxDzahIlyZZVl=
x4RFjHFsFoJgLRZuHQC89B7ta4pXTw7Mirbhgi-2Fg-3D" alt=3D"" width=3D"1" height=
=3D"1" border=3D"0" style=3D"height:1px !important;width:1px !important;bor=
der-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;m=
argin-right:0 !important;margin-left:0 !important;padding-top:0 !important;=
padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !impo=
rtant;"/>
--a695d6af36ee3c70b3499262a0295df31062e27e1fb7c6419bb7947fdccf--
Ok @pibi sounds good I'll look into the scoped package situation
As for the attachment issue, I'll try to take a look as well. We don't use attachments at Starchup (platform I built this for) so I probably didn't notice earlier. Wish email clients were unit-testable (:
Any idea on roughly when you might approve this PR? We could really use it now.
Hi @dtzar,
We are going to revisit re-supporting this library after this PR is accepted: https://github.com/sendgrid/sendgrid-nodejs/pull/378
Thanks!
Elmer
Any news on this @thinkingserious ? @glesage did you try to publish the module as a scoped package?
I was actually just looking but am unclear on what the plan is... I see this commit that @thinkingserious mentioned https://github.com/sendgrid/sendgrid-nodejs/pull/378/commits
but it doesn't seem to have anything different with master, or it's contents have already been merged
Unclear whether I still need to do this fork as a scoped package system @pibi ?
HI @pibi,
We are still working on https://github.com/sendgrid/sendgrid-nodejs/pull/378. We are getting closer, but we still have some work to do. Thanks for checking in!
@glesage,
The plan is to first finish the upgrade of our sendgrid-nodejs package, then we will revisit updating this repo. Thanks!
With Best Regards,
Elmer
Bump - 378 is now merged/closed 👍 Any idea of roughly when you might be able to get to this?
Hello Everyone,
Now that sendgrid-nodejs has been updated, please join the conversation over here.
For this issue to gain priority in our backlog, we need additional +1's or a PR. When we receive a PR, that provides the biggest jump in priority.
With Best Regards,
Elmer