snap-engine icon indicating copy to clipboard operation
snap-engine copied to clipboard

ComponentGeoCoding from master

Open SabineEmbacher opened this issue 4 years ago • 4 comments

SabineEmbacher avatar Sep 27 '21 10:09 SabineEmbacher

Yes, the issue was in the DistanceWeightingInterpolator. https://github.com/senbox-org/snap-engine/commit/21e48e33c9a3311cec909df8d9b76b1bcc1b6f46

Sometimes it changed the incomming PixelPos instance and sometimes it returned a new instance. In the commit above I made it consistent. In the Interpolator a reuse of the PixelPos instance is not intended. While it is for getPixelPos in InverseCoding. That's why the values need to be copied to the existing PixelPos.

marpet avatar Sep 27 '21 12:09 marpet

@SabineEmbacher @martin-boettcher

Is this still releavant? Or can we clode the PR and delete the 8.x.calvalus_cgc branch?

marpet avatar Apr 18 '23 13:04 marpet

@marpet Since this is already 2 years old, I think it is no longer relevant.

But this must bei decided by @martin-boettcher

SabineEmbacher avatar Apr 18 '23 14:04 SabineEmbacher

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 14 '23 08:06 CLAassistant