Cleanup test cases

[mhungen]

Hello, I am currently working on a python port of the s2tbx biophysical models. I have used your auxdata files which contain the model parameters and conveniently a set of test case files.

However, I think there is something wrong with some of the test cases.

Some do not make sense because the structure does not match the model inputs (assuming I’ve correctly interpreted everything).

All test cases of S2B_10m should have 7 columns (6 input, 1 result), but they have 12. All of them are identical to the test cases in S2B, so this looks like a copy & paste error.

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/FAPAR/FAPAR_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/FCOVER/FCOVER_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B_10m/LAI/LAI_TestCases

S2A & S2B test cases for LAI_Cw provide 16 columns, i would expect 12 (11 inputs, 1 result)

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2A/LAI_Cw/LAI_Cw_TestCases
s2tbx-biophysical/src/main/resources/auxdata/3_0/S2B/LAI_Cw/LAI_Cw_TestCases

And there are also some test cases that fail if i add them to your implementation

s2tbx-biophysical/src/main/resources/auxdata/3_0/S2A/LAI_Cab/LAI_Cab_TestCases

To be fair, your code doesn’t use these test cases, but the files are quite large and some of them are clearly wrong. I suggest removing them.

[CLAassistant]

All committers have signed the CLA.