senaite.core icon indicating copy to clipboard operation
senaite.core copied to clipboard

Sample view ignores AS categories

Open andersonsmith opened this issue 5 years ago • 6 comments

Steps to reproduce

View the manage results tab of a sample with multiple categories

Current behavior

Analysis services are listed alphabetically without any categorization.

Expected behavior

AS grouped in categories and respect sort ID's.

Screenshot (optional)

andersonsmith avatar Apr 08 '19 20:04 andersonsmith

Analyses have always been categorized in "Add analyses" views, "Analysis Services" listings, "Sample Add", etc. but as far as I know, they've never been categorized in manage results views

xispa avatar Apr 12 '19 09:04 xispa

In our instance analyses are sorted (not grouped) correctly by category, by sortkey, alphabetically in sample view and manage results view. The demo senaite.ridingbytes.com behaves like @andersonsmith described. The only difference I see, is that there are no sortkeys at all.

grulisco avatar Apr 12 '19 09:04 grulisco

As far as I remember they have been categorized before 1.3.0 and sorted by sort_key with a fallback to alphabetically. Therefore, I think it makes sense to re-add that in the listing

ramonski avatar Apr 12 '19 09:04 ramonski

Got it, apologies for the confusion :+1:

xispa avatar Apr 12 '19 09:04 xispa

Yes, manage results was always categorized in previous versions.

andersonsmith avatar Apr 12 '19 13:04 andersonsmith

More details here: https://github.com/senaite/senaite.core/issues/1400

xispa avatar Nov 26 '19 17:11 xispa

Implemented in https://github.com/senaite/senaite.core/pull/2140

ramonski avatar May 11 '23 14:05 ramonski