semux-core icon indicating copy to clipboard operation
semux-core copied to clipboard

Synchronize the evm changes in go-ethereum to Semux

Open VictorECDSA opened this issue 5 years ago • 5 comments

Is EVM source code in Semux from the EVM module in the "https://github.com/ethereum/ethereumj"? If so, consider that "ethereum/ethereumj" is currently no longer supported. What about the Semux team thinking about synchronizing some of the evm improvements and bug fixes in go-ethereum to Semux? Thank you!

VictorECDSA avatar May 17 '20 16:05 VictorECDSA

No longer supported for eth new forks. Which also, afaik, semux is not supporting or planning to support.

I suppose we will evaluate new eth forked opcode's for VM as they come up.

orogvany avatar May 17 '20 19:05 orogvany

No longer supported for eth new forks. Which also, afaik, semux is not supporting or planning to support.

I suppose we will evaluate new eth forked opcode's for VM as they come up.

What new EVM features are not synchronized to the Semux project? For example, the blake2F precompiled contract in Istanbul fork, or those newly added instructions, and the instructions with changed gas consumption, and so on. Does the Semux team have such a list? Thank you very much!

VictorECDSA avatar May 18 '20 02:05 VictorECDSA

Just as far as Constantinople afaik

orogvany avatar May 18 '20 02:05 orogvany

https://github.com/semuxproject/semux-core/blob/master/src/main/java/org/semux/vm/client/SemuxSpec.java

orogvany avatar May 18 '20 02:05 orogvany

We will certainly accept pull requests if someone wants to propose/implement Istanbul, but given low adoption, I'm not sure its high on dev teams list unless there's known vulnerability

orogvany avatar May 18 '20 02:05 orogvany