intergalactic icon indicating copy to clipboard operation
intergalactic copied to clipboard

Dropdowns a11y [WIP]

Open msereniti opened this issue 3 years ago • 0 comments

Description

I have taken work of @ekrasnopolskaia that was made a month ago and made Select component accessible in the most basic case (without multiselect).

Motivation and Context

Dropdowns&co. are the most inaccessible components if Intergalactic components. Making them accessible will significantly increase accessibility of all library.

How has this been tested?

Currently I have not added tests but planning to add playwright voice over tests.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

Planned todo

  • [ ] Voice over automated tests
  • [ ] Dropdown component accessibility
  • [ ] DropdownMenu component accessibility
  • [ ] AutoSuggest component accessibility
  • [ ] BaseTrigger component warnings if needed aria attributes are not provided

msereniti avatar Sep 02 '22 18:09 msereniti