semrush
[UIK-2421][docs] Added the Add filter pattern
Motivation and Context
=== DON'T MERGE YET ===
I've added a page for the new Add filter pattern. The example is just a copy of the "additional filters" for now, we'll create a proper example after the discussion with designers.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue).
- [x] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
- [ ] Nice improve.
Checklist:
- [ ] My code follows the code style of this project.
- [x] I have updated the documentation accordingly or it's not required.
- [ ] Unit tests are not broken.
- [ ] I have added changelog note to corresponding
CHANGELOG.mdfile with planned publish date. - [ ] I have added new unit tests on added of fixed functionality.
I also was thinking that we will need to check the example in the future from the accessibility point of view.
Yep, I'll probably have to provide some a11y instructions while preparing the task for development, at least focus behavior when adding/removing filters. And then we'll a11y-test the example when it's ready.
What about name? I think AddFilterPattern is not too pretty for the component.
Hm, not sure how to name it. Maybe DynamicFilters? Or maybe team has some ideas.
What about name? I think AddFilterPattern is not too pretty for the component.
Hm, not sure how to name it. Maybe
DynamicFilters? Or maybe team has some ideas.
I'd suggest something like FilterRow
Folks, I've found that input for Position filter shows 2 Clear buttons when there is a value entered 👻
Folks, I've found that input for Position filter shows 2 Clear buttons when there is a value entered 👻
Should be fixed. pull the latest changes
@j-mnizhek Maybe you have some ideas about component name?
Leaving this comment for the history: we've choosen AddFilter for the name.