intergalactic
intergalactic copied to clipboard
[86bzbmj36][side-panel] a11y fixes
Motivation and Context
This PR fixes main issues related to side panel a11y.
- It adds needed role to panel.
- It makes aria-label required
- Semantic footer and header
.Closeand.Backare buttons with thinned paddings now.- Close button got localized aria-label
How has this been tested?
Manually
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
- [x] Nice improve.
Checklist:
- [x] My code follows the code style of this project.
- [x] I have updated the documentation accordingly or it's not required.
- [x] Unit tests are not broken.
- [x] I have added changelog note to corresponding
CHANGELOG.mdfile with planned publish date. - [ ] I have added new unit tests on added of fixed functionality.
@j-mnizhek can you review the docs update? I updated illustrations and some width/paddings information on the Design tab, and also updated the A11y tab. You're also welcome to check out the Examples.