intergalactic
intergalactic copied to clipboard
[86bxrdq3h][input-number] added Intl.NumberFormat formatter
Motivation and Context
How has this been tested?
Manually and I've added some tests
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue).
- [X] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
- [X] Nice improve.
Checklist:
- [X] My code follows the code style of this project.
- [X] I have updated the documentation accordingly or it's not required.
- [X] Unit tests are not broken.
- [X] I have added changelog note to corresponding
CHANGELOG.mdfile with planned publish date. - [X] I have added new unit tests on added of fixed functionality.
Looks like you should also add a new documentation example and update component documentation playground 👀
Looks like you should also add a new documentation example and update component documentation playground 👀
No, because we've changed display value for every number inputs
https://github.com/semrush/intergalactic/assets/31261408/4197f0d3-9c6f-43d5-8cf9-3daf024ada00
https://github.com/semrush/intergalactic/assets/31261408/7ca22b54-9f9c-41ed-bf94-92104df343d7
https://github.com/semrush/intergalactic/assets/31261408/27d7df21-cf9a-43ea-8619-9d47b16efc04
- When I focus on input it changes it's size. I suppose it should not. (first video)
- When I'm trying to select last 3 symbols, selection shifts for 1 symbol. (first video)
cmd+zdoesn't work- When I'm trying to select symbols in the middle of number, selection collapses (second video)
- Screen reader skips first entered symols. Idk why. (third video)
min,max,stepdoesn't work