intergalactic icon indicating copy to clipboard operation
intergalactic copied to clipboard

[86bxrdq3h][input-number] added Intl.NumberFormat formatter

Open ilyabrower opened this issue 1 year ago • 3 comments

Motivation and Context

How has this been tested?

Manually and I've added some tests

Screenshots (if appropriate):

Screenshot 2024-04-01 at 14 33 01

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue).
  • [X] New feature (non-breaking change which adds functionality).
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • [X] Nice improve.

Checklist:

  • [X] My code follows the code style of this project.
  • [X] I have updated the documentation accordingly or it's not required.
  • [X] Unit tests are not broken.
  • [X] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • [X] I have added new unit tests on added of fixed functionality.

ilyabrower avatar Apr 01 '24 12:04 ilyabrower

Looks like you should also add a new documentation example and update component documentation playground 👀

msereniti avatar Apr 02 '24 10:04 msereniti

Looks like you should also add a new documentation example and update component documentation playground 👀

No, because we've changed display value for every number inputs

ilyabrower avatar Apr 02 '24 13:04 ilyabrower

https://github.com/semrush/intergalactic/assets/31261408/4197f0d3-9c6f-43d5-8cf9-3daf024ada00

https://github.com/semrush/intergalactic/assets/31261408/7ca22b54-9f9c-41ed-bf94-92104df343d7

https://github.com/semrush/intergalactic/assets/31261408/27d7df21-cf9a-43ea-8619-9d47b16efc04

  1. When I focus on input it changes it's size. I suppose it should not. (first video)
  2. When I'm trying to select last 3 symbols, selection shifts for 1 symbol. (first video)
  3. cmd+z doesn't work
  4. When I'm trying to select symbols in the middle of number, selection collapses (second video)
  5. Screen reader skips first entered symols. Idk why. (third video)
  6. min, max, step doesn't work

msereniti avatar Apr 05 '24 15:04 msereniti