amica icon indicating copy to clipboard operation
amica copied to clipboard
verified publisher icon semperai

enhancement-implemented

Open agrim0312 opened this issue 2 years ago • 8 comments

changed - Link to CustomLink in ./common.tsx due to conflict of same names

Screencast from 17-12-23 05:04:10 PM IST.webm

however, did not delete the share page file

agrim0312 avatar Dec 17 '23 11:12 agrim0312

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amica ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 0:53am

vercel[bot] avatar Dec 17 '23 11:12 vercel[bot]

fixed #52

agrim0312 avatar Dec 17 '23 11:12 agrim0312

Hi @agrim0312 thank you. However, can't merge yet as it looks like this broke the build. You can check locally by running npm run build to run the typechecker.

kasumi-1 avatar Dec 17 '23 12:12 kasumi-1

sure

agrim0312 avatar Dec 17 '23 12:12 agrim0312

@kasumi-1 fixed the build You can review it now

agrim0312 avatar Dec 17 '23 12:12 agrim0312

This freezes the character when closed. Also, there are some whitespace and indent issues - I fixed these in https://github.com/semperai/amica/tree/sharePage-2-modal-component but I am unsure of cause of freezing on close.

kasumi-1 avatar Dec 17 '23 19:12 kasumi-1

hi @kasumi-1, I am not able to solve the issue however I have narrowed it down. As soon as VrmDemo gets loaded in the shareModal.tsx file the character freezes. I tried rendering modal without VrmDemo and it did'nt freeze and worked fine. Screenshot from 2023-12-18 17-18-11 here is the VrmDemo div. Please guide me so that I can fix the issue.

agrim0312 avatar Dec 18 '23 11:12 agrim0312

I think this PR is resolved with the load/save VRM feature added. Will double check in future.

slowsynapse avatar May 14 '24 22:05 slowsynapse