bento icon indicating copy to clipboard operation
bento copied to clipboard

Bento autorun should skip if files are exclusively deleted

Open ievans opened this issue 5 years ago • 5 comments

Make a commit that deletes files only. Git commit it with bento autorun enabled:

git commit -am "comment ifelse for platform run"
Running Bento checks on staged files...

⚠ Nothing to check or archive. Please confirm that changes are staged and not
excluded by `.bentoignore`. To check all Git tracked files, use `--all`.

✔ 0 findings due to staged changes in 0.00 s

Desired behavior: It would be nice if Bento didn't run if the commit is just deleting files. Bento version: 0.9.1

ievans avatar Feb 21 '20 02:02 ievans

@ievans Thanks for filing. To clarify, were you prevented from merging or did another bug occur? If not, marking this as an enhancement.

dlukeomalley avatar Feb 21 '20 15:02 dlukeomalley

Not prevented from merging, enhancement is fine

ievans avatar Feb 21 '20 16:02 ievans

@ievans As a follow up, can you describe what this helps you with? E.g. are you concerned about commit speed, or do you find the text surprising?

nbrahms avatar Mar 03 '20 00:03 nbrahms

Just find the text surprising

ievans avatar Mar 03 '20 01:03 ievans

Great, thanks for the update

nbrahms avatar Mar 03 '20 16:03 nbrahms