django-smuggler icon indicating copy to clipboard operation
django-smuggler copied to clipboard

Dump filenames without spaces

Open jayvdb opened this issue 3 years ago • 1 comments

Filenames for /app/model/dump end up as app-model-_2021-02-05T12 25 46.775165.yaml for me. It would be simpler to use these filenames didnt contain spaces ( ), or even :. Also the _ before the year, i.e. -_2021 is a bit odd. i.e. ISO 8601 without the colons would be ideal, especially in UTC given the file could be moved across timezones, and thus the stamp should be terminated with Z.

jayvdb avatar Feb 05 '21 12:02 jayvdb

The datetime part of the filename is appended here: https://github.com/semente/django-smuggler/blob/695699d30823f70d4e40f5442098f4899ca83f43/smuggler/views.py#L38-L39, a patch that replaces the colon with an empty string will probably be accepted.

The app-model bit before the timestamp probably comes from here: https://github.com/semente/django-smuggler/blob/695699d30823f70d4e40f5442098f4899ca83f43/smuggler/views.py#L86-L87, I'm not sure how the extra dash ends up there. If you can find out why, a patch that fixes is will be appreciated.

jaap3 avatar Feb 06 '21 13:02 jaap3