sematable icon indicating copy to clipboard operation
sematable copied to clipboard

Custom sort icons and pagination classes

Open godd9170 opened this issue 7 years ago • 3 comments

Hi There,

Found this repo via a blog post on a pursuit to make jquery DataTables Frankenstein into a React-Redux project. It really peaked my interest and I've since been tinkering with Sematable for about a day now.

This PR introduces the option for custom sorting icons, as well as extends the option to set paginationContainerClassName and paginationClassName. Seemed like a natural option given both pageSize and filter had them.

Let me know what you think.

godd9170 avatar Jul 25 '17 22:07 godd9170

Hey @otisg ,

Take a look and let me know if this PR abides with what you're trying to achieve with Sematable. I've added a few config options that are outlined in the README. I'm pretty happy with the added functionality in my own project and it certainly introduces no breaking changes.

-H

godd9170 avatar Jul 27 '17 16:07 godd9170

@amir-hadzic will be able to look at this (but in a few weeks, after returning from vacation)

otisg avatar Jul 27 '17 17:07 otisg

Awesome, no rush! Really thankful for the repo thus far. Happy Vacation @amir-hadzic

godd9170 avatar Jul 27 '17 17:07 godd9170

Thanks for that effort, @godd9170. The project was deprecated on Mar 7, 2022. Closing the PR.

mbonaci avatar Oct 10 '23 21:10 mbonaci