semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard

Add a new type secret in Survey Variable

Open sparsick opened this issue 2 years ago • 1 comments

Sometimes you want to add a password etc. and hide their value. Therefore, I add a new type 'secret' so this input field will hide the typed value is hidden.

Relates to #904

sparsick avatar Oct 27 '23 08:10 sparsick

@fiftin Is this PR okay, or should I do more so that it can be merged?

sparsick avatar Dec 13 '23 15:12 sparsick

I need this feature! 💯

joseangel-piqueras avatar Mar 06 '24 07:03 joseangel-piqueras

This feature could be misleading. It just hides the input and doesn't handling the actual value as a secret thus someone password will be saved in clear text. The value is easily readable inside the browsers network tab.

My improvement idea:

  • The secret survey "key:value" pairs would be sent to the backend in a different key than "environment" thus it will be separated.
  • Handling the secrets on the backend only need to differ from environments in one place: not saving them to the db.
  • This will break the rerun function, because there will be missing variables, so secret survey fields should always be empty and required for a rerun.

I didn't look into how hard it is to implement this idea or if it's even possible. I might later this week, when i have time.

tothakos-code avatar Mar 11 '24 13:03 tothakos-code

Merged @tothakos-code solution. Thank you.

fiftin avatar May 20 '24 13:05 fiftin