semaphore icon indicating copy to clipboard operation
semaphore copied to clipboard

Semaphore can't use ansible.posix.synchronize because rsync is missing in the Docker container

Open ziermmar opened this issue 2 years ago • 2 comments

Using the provided image: semaphoreui/semaphore, one can't use the module ansible.posix.synchronize out of the box.

ansible.posix.synchronize is just a wrapper around rsync, which is missing in the image

ziermmar avatar Oct 12 '23 12:10 ziermmar

I just noticed, similar dependency issues are already being discussed and addressed in #1498, however rsync is not a python library dependency

ziermmar avatar Oct 12 '23 12:10 ziermmar

It would probably be fixed by just adding rsync here

RUN apk add --no-cache sshpass git curl ansible mysql-client openssh-client-default tini py3-aiohttp && \
    adduser -D -u 1001 -G root semaphore && \
    mkdir -p /tmp/semaphore && \
    mkdir -p /etc/semaphore && \
    mkdir -p /var/lib/semaphore && \
    chown -R semaphore:0 /tmp/semaphore && \
    chown -R semaphore:0 /etc/semaphore && \
    chown -R semaphore:0 /var/lib/semaphore

I'll probably open PR myself if it doesn't get fix by the end of this month.

EDIT: Just saw your PR, it's so sad that it doesn't get merged

Zen3515 avatar Jan 10 '24 11:01 Zen3515

The rsync package have been already added, this should work with a current version.

tboerger avatar Mar 02 '24 12:03 tboerger

I still get errors like FAILED! => {"changed": false, "msg": "Failed to find required executable \"rsync\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"} with version v2.9.64 from hub.docker.com.

Is it because this line does not contain a reference to rsync? https://github.com/semaphoreui/semaphore/blob/5c507329143d97ba2f139e3d905d2eef78b2913a/deployment/docker/prod/buildx.Dockerfile#L16

Apollo3zehn avatar Apr 03 '24 19:04 Apollo3zehn

Yeah there is a drift between the images, we need to get this straight.

tboerger avatar Apr 10 '24 06:04 tboerger

Hey. How is this going?

airone01 avatar May 02 '24 15:05 airone01

It is part of the develop tag now and will be soon part of the next version.

tboerger avatar May 08 '24 10:05 tboerger