Simon Perepelitsa

Results 17 comments of Simon Perepelitsa

Would like to know the reason behind deprecations as well, considering Readme still recommends using them 🙂

These options are easy enough to implement on client-side. If they are not offered by other implementations, dropping them seems fine. But `:empty_string=>false` behavior is how it works by default...

May I also suggest to make it more concise by describing attribute as a whole instead of getter/setter methods individually. Before - _cache_strings=_ sets the value of the _cache_strings_ to...

At the moment, `ActiveRecord::Base.send(:impl_class)` is reserved for your library, but the method name doesn't contain "with advisory lock", so it could be easily used by other libraries or application code....

The same error, unfortunately. ``` You have a nil object when you didn't expect it! You might have expected an instance of Array. The error occurred while evaluating nil.+ /Users/sema/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/colorific-1.0.2/lib/colorific.rb:75:in...

I'm not sure that I run them properly but here is the result: ``` bundle exec testrb test/test_error.rb test/test_fail.rb test/test_nothing.rb test/test_pass.rb test/test_skip.rb Run options: # Running tests: /Users/sema/Code/colorific/lib/colorific.rb:75:in `block in...

I'm using Safari 5.1.3, OS X 10.7.3