github icon indicating copy to clipboard operation
github copied to clipboard

ref: Remove usage of aggregate-error library

Open AbhiPrasad opened this issue 1 year ago • 2 comments

ref https://github.com/semantic-release/semantic-release/discussions/3376 ref https://github.com/es-tooling/module-replacements/issues/80

As per the package.json engines of this package, @semantic-release/github supports Node.js >=20.8.1.

As per https://github.com/sindresorhus/aggregate-error

Note: With Node.js 15, there's now a built-in AggregateError type.

This means we can remove the usage of this package and use the JavaScript built-in AggregateError.

AbhiPrasad avatar Jul 02 '24 02:07 AbhiPrasad

I agree @AbhiPrasad 👍

Kindly address the following to get the PR ready for review 😉

  • Tests failing in CI: Due to lint issues, kindly run the command npm run lint:prettier:fix on your dev branch... then run the tests again see whether it passes.

babblebey avatar Jul 08 '24 15:07 babblebey

@babblebey thank you for the review! I am waiting on a decision in https://github.com/semantic-release/semantic-release/pull/3377 to continue work on this PR.

AbhiPrasad avatar Jul 08 '24 15:07 AbhiPrasad