github icon indicating copy to clipboard operation
github copied to clipboard

refactor: singleton `octokit` instance for shared throttling state

Open gr2m opened this issue 2 years ago • 2 comments
trafficstars

gr2m avatar May 29 '23 23:05 gr2m

are we wanting to include this refactor in the ESM change, or follow up with it afterward? i've had no problems in my testing with the current beta that includes the ESM change for our two candidate plugins, so wondering if we promote those candidates or wait for this change to go in

travi avatar Jun 02 '23 17:06 travi

only comments are calling out most of your todos. am i correct to assume that is most of what remains for this to still be draft

correct

are we wanting to include this refactor in the ESM change, or follow up with it afterward

I planned to give this another go today but I won't have time. I'd say let's go ahead with the ESM change and then do this afterwards.

gr2m avatar Jun 02 '23 19:06 gr2m