python-user-agents icon indicating copy to clipboard operation
python-user-agents copied to clipboard

Published 20 hours ago • verified publisher icon selwin

Add all install requirements to setup.py

Open AndreasBackx opened this issue 7 years ago • 3 comments

In the readme it tells people to install pyyaml and ua-parser alongside this library. ua-parser seems to be included in the setup.py, but pyyaml is not. I'm up to make PR, but I don't know what the minimum required version of pyyaml is. Could you add pyyaml to the setup.py and edit the readme?

AndreasBackx avatar Aug 26 '16 23:08 AndreasBackx

Pretty sure this is solved by https://github.com/selwin/python-user-agents/commit/9ad93b8f7972f1a7c3da237506afbf696e8447d7 so this ticket can be closed.

robcowie avatar Mar 26 '17 10:03 robcowie

@robcowie pyyaml still doesn't seem to be added which is why I created this issue. Unless the library no longer needs it?

AndreasBackx avatar Mar 27 '17 06:03 AndreasBackx

Ah I see. I'm pretty sure the readme is wrong. pyyaml isn't a requirement for this library and it's only a requirement for ua-parser during install (it's declared in setup_requires, https://github.com/ua-parser/uap-python/blob/master/setup.py#L186).

Certainly it seems to work in a fresh virtualenv for me without explicitly installing pyyaml. Can you confirm that?

robcowie avatar Mar 27 '17 11:03 robcowie